-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pcd_map_validator): create tool for validating pcd maps #166
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request!
I will test this tool with approximately 30 PCD files.
First, I left a comment about the maintainer field in the package.xml file. Please check it.
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update! I have added two comments for clarification. Could you please review them?
Tuple[float, np.ndarray]: Tuple containing: | ||
- Average resolution (mean distance between points) | ||
- Array of distances for each point | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might be a disagreement between the commented out description and the actual behavior. The following "Note:" says that the function "compute_resolution" focuses on k-1 nearest neighbors (excluding the point itself), but the actual function looks counting k (= k +1 -1) nearest neighbors to me.
<maintainer email="[email protected]">Anh Nguyen</maintainer> | ||
<maintainer email="[email protected]">Masahiro Sakamoto</maintainer> | ||
<maintainer email="[email protected]">Taiki Yamada</maintainer> | ||
<maintainer email="[email protected]">Yamato Ando</maintainer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to add:
<maintainer email="[email protected]">Kei Nakazato</maintainer>
Description
Create tools for validation pcd maps.
This script provides comprehensive analysis tools for point cloud data, including:
As background, Pilot-Auto has a PCD map requirement documentation. However, there is no standardized way or tools on how to perform quality check of the pcd maps. We relied on human eyes to check the quality of point cloud maps.
This script is the script created for an internal project. It provides key statistics for us to judge the point cloud maps from a bigger picture, and also it produces colorized point clouds for easier identifying point cloud errors with human eyes.
Please feel free to provide feedback on how to improve this tool.
Related links
Pilot-Auto PCD map requirement documentation
TIER IV INTERNAL TICKET LINK
TIER IV INTERNAL DISCUSSION LINK
Tests performed
I visualized multiple pointcloud maps.
My favourite command will be
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.